PDA

View Full Version : How To Shorten Superfluous Code From Recorded Macro



rodneykaye
10-21-2013, 05:16 PM
Trying to learn VBA using macro recorder.How would you shorten this code?
How do you determine what can or cannot be removed?
Regards
Rodney


https://www.youtube.com/channel/UCnxwq2aGJRbjOo_MO54oaHA (https://www.youtube.com/channel/UCnxwq2aGJRbjOo_MO54oaHA)
https://www.reddit.com/r/windowsxp/comments/pexq9q/comment/k81ybvj/?utm_source=reddit&utm_medium=web2x&context=3 (https://www.reddit.com/r/windowsxp/comments/pexq9q/comment/k81ybvj/?utm_source=reddit&utm_medium=web2x&context=3)
https://www.youtube.com/watch?v=bs-urI_o8jo&lc=UgxYgiEZuS9I3xkjJv54AaABAg (https://www.youtube.com/watch?v=bs-urI_o8jo&lc=UgxYgiEZuS9I3xkjJv54AaABAg)
https://www.youtube.com/watch?v=bs-urI_o8jo&lc=UgyBACXgNY4j_cHgH5J4AaABAg.9oTkVdzfqfm9wlhQrYJP 3M (https://www.youtube.com/watch?v=bs-urI_o8jo&lc=UgyBACXgNY4j_cHgH5J4AaABAg.9oTkVdzfqfm9wlhQrYJP 3M)
ttps://www.youtube.com/watch?v=LP9fz2DCMBE (ttps://www.youtube.com/watch?v=LP9fz2DCMBE)
https://www.youtube.com/watch?v=LP9fz2DCMBE&lc=UgzbPgJUMCztIOQDym14AaABAg (https://www.youtube.com/watch?v=LP9fz2DCMBE&lc=UgzbPgJUMCztIOQDym14AaABAg)
https://www.youtube.com/watch?v=LP9fz2DCMBE&lc=UgzbPgJUMCztIOQDym14AaABAg.9wdo_rWgxSH9wdpcYqrv p8 (https://www.youtube.com/watch?v=LP9fz2DCMBE&lc=UgzbPgJUMCztIOQDym14AaABAg.9wdo_rWgxSH9wdpcYqrv p8)
ttps://www.youtube.com/watch?v=bFxnXH4-L1A (ttps://www.youtube.com/watch?v=bFxnXH4-L1A)
https://www.youtube.com/watch?v=bFxnXH4-L1A&lc=UgxuODisjo6cvom7O-B4AaABAg.9w_AeS3JiK09wdi2XviwLG (https://www.youtube.com/watch?v=bFxnXH4-L1A&lc=UgxuODisjo6cvom7O-B4AaABAg.9w_AeS3JiK09wdi2XviwLG)
https://www.youtube.com/watch?v=bFxnXH4-L1A&lc=UgxBU39bTptFznDC1PJ4AaABAg (https://www.youtube.com/watch?v=bFxnXH4-L1A&lc=UgxBU39bTptFznDC1PJ4AaABAg)
ttps://www.youtube.com/watch?v=GqzeFYWjTxI (ttps://www.youtube.com/watch?v=GqzeFYWjTxI)
https://www.youtube.com/watch?v=GqzeFYWjTxI&lc=UgwJnJDJ5JT8hFvibt14AaABAg (https://www.youtube.com/watch?v=GqzeFYWjTxI&lc=UgwJnJDJ5JT8hFvibt14AaABAg)
https://www.youtube.com/channel/UCnxwq2aGJRbjOo_MO54oaHA (https://www.youtube.com/channel/UCnxwq2aGJRbjOo_MO54oaHA)

patel
10-21-2013, 09:27 PM
Sub Macro1()
Range("E4:N23").Select
Selection.Borders.LineStyle = xlContinuous

End Sub

Excel Fox
10-21-2013, 10:03 PM
Don't need to write 'Select'


Range("E4:N23").Borders.LineStyle = xlContinuous

Kenneth Hobson
10-22-2013, 12:14 AM
To go beyond the recorder: Beyond Excel's recorder (http://www.tushar-mehta.com/excel/vba/beyond_the_macro_recorder/)

rodneykaye
10-22-2013, 09:17 AM
Thanks for the help

I used the recorder and deleted much of the code....i attached workbook....could this be made even simpler?

Regards

RK

Kenneth Hobson
10-22-2013, 05:54 PM
The fewer times that you reference an object the better. This is easy to read anyway.

Private Sub CommandButton2_Click()
With Range("E4:N4")
.Interior.ColorIndex = 3
.Font.Bold = True
.Font.Size = 16
.Font.Color = rgbWhite
.FormulaR1C1 = "=RC[-1]+1"
End With
Range("E4").FormulaR1C1 = "=TODAY()"
Range("E4:N23").Borders.LineStyle = xlContinuous
Columns("E:N").ColumnWidth = 17.14
End Sub